Skip to content

lib/types: add types json from pkgs.formats #470842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hsjobeki wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lib/types: add types json from pkgs.formats #470842

hsjobeki wants to merge 2 commits into from

Conversation

@hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Dec 14, 2025 •
edited
Loading

Motivation:

Issue: #468919

Todo:

  • add unit tests for the type

Note:
I removed the unused "nullable" parameter in pkgs.formats mkStructuredType
It wasn't used anywhere.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@hsjobeki hsjobeki requested a review from h7x4 December 14, 2025 21:01
@nixpkgs-ci nixpkgs-ci bot requested a review from Stunkymonkey December 14, 2025 21:07
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 14, 2025
@hsjobeki hsjobeki changed the title pkgs/formats: remove unused nullable parameter from 'mkStructuredType' lib/types: add types json from pkgs.formats Dec 14, 2025
@nixpkgs-ci nixpkgs-ci bot requested review from infinisil and roberth December 14, 2025 21:23
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: module system About "NixOS" module system internals 6.topic: lib The Nixpkgs function library and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 14, 2025
@nixpkgs-ci nixpkgs-ci bot added the 8.has: documentation This PR adds or changes documentation label Dec 14, 2025
roberth
roberth reviewed Dec 14, 2025
View reviewed changes
@hsjobeki hsjobeki mentioned this pull request Dec 18, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth roberth left review comments

@h7x4 h7x4 Awaiting requested review from h7x4

@Stunkymonkey Stunkymonkey Awaiting requested review from Stunkymonkey

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: lib The Nixpkgs function library 6.topic: module system About "NixOS" module system internals 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

Nixpkgs Lib
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hsjobeki @roberth @Stunkymonkey