nixos/kubernetes: fix infra image pinning #470971
Open
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All kubernetes pods have an infra container (using `pause:latest`) to setup networking etc. This image is loaded into containerd when kubelet starts. However, due to a misconfiguration the image can get GC-ed and kubelet tries to pull it from Docker Hub but the image does not exist there. This prevents any new pods from being created. Pinning of the infra image for kubernetes is delegated to the CRI implementation (containerd) since Kubernetes 1.29, and the `--pod-infra-container-image` flag does nothing and will be fully removed in 1.35. containerd (config version 2) uses the `sandbox_image` setting to know what images to pin. However, while it normalizes `pause:latest` to `docker.io/library/pause:latest` in the image list, it does not normalize the setting value when checking if the image should be pinned or not. Using the fully qualified name in the setting is enough to make it be correctly pinned after a full containerd restart.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
johanot
approved these changes
Dec 16, 2025
Contributor
johanot
left a comment
johanot
left a comment
There was a problem hiding this comment.
Tested this branch vs. nixos-unstable locally and can indeed confirm the behavior. Thanks for fixing this!
Contributor
|
@ofborg test kubernetes |
nixpkgs-ci
bot
added
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All kubernetes pods have an infra container (using
pause:latest) to setup networking etc. This image is loaded into containerd when kubelet starts. However, due to a misconfiguration the image can get GC-ed and kubelet tries to pull it from Docker Hub but the image does not exist there. This prevents any new pods from being created.Pinning of the infra image for kubernetes is delegated to the CRI implementation (containerd) since Kubernetes 1.29, and the
--pod-infra-container-imageflag does nothing and will be fully removed in 1.35.containerd (config version 2) uses the
sandbox_imagesetting to know what images to pin. However, while it normalizespause:latesttodocker.io/library/pause:latestin the image list, it does not normalize the setting value when checking if the image should be pinned or not. Using the fully qualified name in the setting is enough to make it be correctly pinned after a full containerd restart.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.