Skip to content

treewide(python): format using ruff #471048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PerchunPak wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

treewide(python): format using ruff #471048

PerchunPak wants to merge 3 commits into from

Conversation

@PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Dec 15, 2025

Ruff is an extremely fast Python linter and code formatter. It is currently the best option for a formatter in Python. I thought it would be nice to add it as a formatter

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: kernel The Linux kernel 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: vim Advanced text editor 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: games Gaming on NixOS 6.topic: julia Julia is a high-level, high-performance dynamic language for technical computing. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: dotnet Language: .NET 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 8.has: documentation This PR adds or changes documentation backport release-25.05 Backport PR automatically backport release-25.11 Backport PR automatically labels Dec 15, 2025
@mdaniels5757 mdaniels5757 changed the base branch from master to staging December 17, 2025 00:56
@nixpkgs-ci nixpkgs-ci bot closed this Dec 17, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 17, 2025
@mdaniels5757 mdaniels5757 removed backport release-25.05 Backport PR automatically backport release-25.11 Backport PR automatically labels Dec 17, 2025
@mdaniels5757
Copy link
Member

mdaniels5757 commented Dec 17, 2025 •
edited
Loading

I untagged for automatic backport: it is rather unlikely that none of these files will have a merge conflict. :)

The best approach for backporting, once this is merged, would probably be to create a branch based on staging-25.11, cherry-pick the first two commits, then re-run treefmt.

@nixpkgs-ci nixpkgs-ci bot added backport release-25.05 Backport PR automatically backport release-25.11 Backport PR automatically labels Dec 17, 2025
@PerchunPak
Copy link
Member Author

PerchunPak commented Dec 17, 2025

I untagged for automatic backport: it is rather unlikely that none of these files will have a merge conflict. :)

I agree, but it looks like CI insists on a backport

@PerchunPak PerchunPak added backport staging-25.05 Backport PR automatically backport staging-25.11 Backport PR automatically and removed backport release-25.05 Backport PR automatically backport release-25.11 Backport PR automatically labels Dec 17, 2025
@mdaniels5757
Copy link
Member

mdaniels5757 commented Dec 17, 2025

Ah, I guess it's because you're touching ci/default.nix. Annoying.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: dotnet Language: .NET 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: games Gaming on NixOS 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: julia Julia is a high-level, high-performance dynamic language for technical computing. 6.topic: kernel The Linux kernel 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. backport staging-25.05 Backport PR automatically backport staging-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PerchunPak @mdaniels5757