Skip to content

Conversation

@sweenu
Copy link
Contributor

@sweenu sweenu commented Jan 6, 2026

Closes #472698

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 6, 2026
@sweenu sweenu requested a review from gepbird January 6, 2026 13:18
@sweenu
Copy link
Contributor Author

sweenu commented Jan 6, 2026

I deployed it and don't see any issues so far.

@sweenu sweenu marked this pull request as ready for review January 6, 2026 13:19
@nixpkgs-ci nixpkgs-ci bot requested a review from AdrienLemaire January 6, 2026 13:23
@gepbird
Copy link
Contributor

gepbird commented Jan 6, 2026

Thanks for becoming a maintainer and pushing n8n v2!

There are breaking changes documented in https://docs.n8n.io/2-0-breaking-changes/, I think a sentence with this link could be included in the release notes.
Also, for the NixOS module we could add warnings/assertions for deprecated environment variables like QUEUE_WORKER_MAX_STALLED_COUNT and N8N_CONFIG_FILES. Not entirely sure about this since it wasn't explicitly defined in the NixOS module and seems like this is not a common option to set.

@sweenu
Copy link
Contributor Author

sweenu commented Jan 6, 2026

image

I haven't added anything to my own deployment, so I don't understand why it reports any issues with my instance 🤔

Do you want me to add those warning in the same PR ?

@sweenu
Copy link
Contributor Author

sweenu commented Jan 6, 2026

Added the release note warning.

@nixpkgs-ci nixpkgs-ci bot added 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 6, 2026
Copy link
Contributor

@gepbird gepbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That in-app v2 compatibility is neat, let's skip adding warnings/asserts in the module.
It's only 2 environment variables that are removed and there are many other breaking changes that we can't really cover.

@gepbird
Copy link
Contributor

gepbird commented Jan 6, 2026

I haven't added anything to my own deployment, so I don't understand why it reports any issues with my instance 🤔

That's interesting, for example we don't specify --tunnel from nixpkgs and I assume you don't either but it n8n asks you to remove it.

Do you want me to add those warning in the same PR ?

Release note warning should go in this PR as you did.

@sweenu sweenu requested review from gepbird and removed request for AdrienLemaire January 6, 2026 18:47
@nixpkgs-ci nixpkgs-ci bot requested a review from AdrienLemaire January 6, 2026 18:51
@gepbird
Copy link
Contributor

gepbird commented Jan 6, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 477422
Commit: b77c563ed6411f300e479ed28dfae63cab707a8e


x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
✅ 2 packages built:
  • n8n
  • nixpkgs-manual

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 6, 2026
@nixpkgs-ci nixpkgs-ci bot added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jan 6, 2026
@gepbird
Copy link
Contributor

gepbird commented Jan 7, 2026

I don't think the false positives in the compatibility reports are blocking, I don't see how it could be a packaging issue.
Do you think we should go forward with this or try to find what causes that first?

@sweenu
Copy link
Contributor Author

sweenu commented Jan 7, 2026

Yeah, it seems like the tool was made to be run in 1.x before upgrading, they don't check if you're already in 2.x.
https://docs.n8n.io/migration-tool-v2/#instance-issues-tab

@gepbird gepbird added this pull request to the merge queue Jan 7, 2026
Merged via the queue into NixOS:master with commit 9995f8e Jan 7, 2026
34 of 36 checks passed
@gepbird gepbird mentioned this pull request Jan 8, 2026
@leona-ya leona-ya added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 9, 2026
@leona-ya
Copy link
Member

leona-ya commented Jan 9, 2026

This solves GHSA-62r4-hw23-cc8v, we need to do something about 25.11.

@gepbird
Copy link
Contributor

gepbird commented Jan 9, 2026

This solves GHSA-62r4-hw23-cc8v, we need to do something about 25.11.

What would be the correct action to take here? Can we detect whether the instance is vulnerable by checking some settings at eval time? Some of my ideas:

  1. set N8N_RUNNERS_ENABLED = true and N8N_NATIVE_PYTHON_RUNNER = true on 25.11, I don't if this could break some workflows
  2. ask upstream to create a fix on n8n v1 or ask if it was fixed in case the GHSA is inaccurate, finally backport the latest v1
  3. backport this breaking change
  4. lighter backport: create an n8n_2 package on 25.11 (remove that next release), add a warning to the module, I imagine this would result in some/many false positives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants