-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
n8n: 1.123.5 -> 2.3.0 #477422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n8n: 1.123.5 -> 2.3.0 #477422
Conversation
|
I deployed it and don't see any issues so far. |
|
Thanks for becoming a maintainer and pushing n8n v2! There are breaking changes documented in https://docs.n8n.io/2-0-breaking-changes/, I think a sentence with this link could be included in the release notes. |
|
Added the release note warning. |
gepbird
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That in-app v2 compatibility is neat, let's skip adding warnings/asserts in the module.
It's only 2 environment variables that are removed and there are many other breaking changes that we can't really cover.
That's interesting, for example we don't specify
Release note warning should go in this PR as you did. |
|
|
I don't think the false positives in the compatibility reports are blocking, I don't see how it could be a packaging issue. |
|
Yeah, it seems like the tool was made to be run in 1.x before upgrading, they don't check if you're already in 2.x. |
|
This solves GHSA-62r4-hw23-cc8v, we need to do something about 25.11. |
What would be the correct action to take here? Can we detect whether the instance is vulnerable by checking some settings at eval time? Some of my ideas:
|

Closes #472698
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.