fix: add missing KZG point evaluation precompile #5100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5f46e74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
agostbiro
requested changes
Apr 10, 2024
Member
|
Change request: it looks like there is a new transitive dependency that doesn't build on Windows. |
fvictorio
reviewed
Apr 11, 2024
| reqwest-retry = { version = "0.3.0", default-features = false } | ||
| reqwest-tracing = { version = "0.4.7", default-features = false, optional = true } | ||
| revm-primitives = { version = "3.0", default-features = false } | ||
| revm-primitives = { git = "https://github.com/Wodann/revm", rev = "451f122", version = "3.1", default-features = false, features = ["hashbrown"] } |
Member
There was a problem hiding this comment.
Q: why are we using a fork again here?
Member
Author
There was a problem hiding this comment.
We upstreamed 2 changes to revm that:
- was merged but not released yet
- was not merged yet
fvictorio
approved these changes
Apr 12, 2024
Wodann
force-pushed
the
edr/fix/full-block
branch
from
69e3407 to
03796a3
Compare
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
agostbiro
approved these changes
Apr 12, 2024
Member
agostbiro
left a comment
agostbiro
left a comment
There was a problem hiding this comment.
Thanks, LGTM assuming CI passes.
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Wodann
force-pushed
the
edr/fix/full-block
branch
from
54a8716 to
18f62dc
Compare
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Wodann
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of fixing this, I also updated all Rust dependencies to ensure that we could use the latest version of
revm(v8.0.0)Depends on