Skip to content

Conversation

MartinXPN
Copy link
Contributor

@MartinXPN MartinXPN commented Aug 4, 2022

Description

Fixes #199

This PR fixes the newline issue in simple tables.
Before: All the lines in table cells were shown on a single line.
Now: The newlines are respected if present in the table cells.

Notion Test Page ID

https://mango-woodwind-d3c.notion.site/Demo-7a15103d327f4c108a826ffcfd3f8373

@vercel
Copy link

vercel bot commented Aug 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-notion-x ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 5:48PM (UTC)
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 5:48PM (UTC)

@MartinXPN
Copy link
Contributor Author

Hi @transitive-bullshit , can you please review this?
I currently have an app in production that would benefit a lot from this small change.

Thanks a lot!

@transitive-bullshit transitive-bullshit merged commit 8ff6f5a into NotionX:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Simple Tables] Newlines within the cells of simple tables are not rendered

2 participants