Remove temp patching for deps.json #3552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heng-liu
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
kartheekp-ms,
nkolev92,
rrelyea,
zivkan and
zkat
as code owners
nkolev92
reviewed
Aug 3, 2020
build/packages.targets
Outdated
| <VSServicesVersion>16.153.0</VSServicesVersion> | ||
| <VSThreadingVersion>16.6.13</VSThreadingVersion> | ||
| <!-- TODO - remove this when temporary patching is no longer necessary. See https://github.com/nuget/home/issues/8952 --> | ||
| <PatchedSystemPackagesVersion>5.0.0-preview.3.20214.6</PatchedSystemPackagesVersion> |
Member
There was a problem hiding this comment.
You only removed the comment.
How about the property variable?
Contributor
Author
There was a problem hiding this comment.
Thanks for reviewing!
The property PatchedSystemPackagesVersion is still needed, as the System.Security.Cryptography.Pkcs/Cng are not in the .NET 5 Base Class Libraries (BCL). We need to keep the package referrence of System.Security.Cryptography.Pkcs/Cng.
So only the comment should be removed.
Member
There was a problem hiding this comment.
Should we change the name to a property that communicates the intention better?
Maybe something like CryptographyPackagesVersion or similar.
nkolev92
approved these changes
Aug 5, 2020
Member
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
Nice :)
Happy to see this cleanup.
👏
heng-liu
force-pushed
the
dev-hengliu-xplat2-remove-patching
branch
2 times, most recently
from
8cf91bd to
fa52013
Compare
zivkan
approved these changes
Aug 11, 2020
heng-liu
force-pushed
the
dev-hengliu-xplat2-remove-patching
branch
from
040b282 to
cc7e4b9
Compare
heng-liu
force-pushed
the
dev-hengliu-xplat2-remove-patching
branch
from
cc7e4b9 to
a35add7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8952 and https://github.com/NuGet/Client.Engineering/issues/367
Regression: No
Fix
Details:
Remove the patching on deps.json files in Dotnet.Integration.Test.
Remove the comments as we need package referrenc of System.Security.Cryptography.Pkcs/Cng as they're not part of the .NET 5 Base Class Libraries (BCL)
Update the version of dotnet sdk for testing to a newer version, as the old one doesn't have Pkcs.dll.
Update the version of dotnet sdk for building to the latest public version(preview7).
Testing/Validation
Tests Added: No
Reason for not adding tests:
Validation: