Use HttpRequestMessage.Options instead of Properties on net5.0 #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dotnet/runtime PR marked Properties as obsolete: dotnet/runtime#39182 Since we use warnings as errors, we have to change our code.
Member
|
Well the notification worked for me :D It ended up in the right folder so I'm happy :D |
nkolev92
approved these changes
Aug 31, 2020
src/NuGet.Core/NuGet.Protocol/HttpSource/HttpSourceAuthenticationHandler.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dotnet/runtime PR marked Properties as obsolete:
dotnet/runtime#39182
Since we use warnings as errors, we have to change our code.
Bug
Fixes: NuGet/Home#9964
Regression: No
Fix
Details: Add some
#if NET5_0that will cause problems when we eventually move to NET6.0, but we can deal with this later.Testing/Validation
Tests Added: No
Reason for not adding tests: I expect existing tests to cover it. This change did not change any APIs or expected behaviour.
Validation: