Skip to content

Remove unecessary casts from NuGetSdkResolver #4512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dfederm wants to merge 1 commit into from
Closed

Remove unecessary casts from NuGetSdkResolver #4512

dfederm wants to merge 1 commit into from

Conversation

@dfederm
Copy link
Contributor

@dfederm dfederm commented Mar 23, 2022 •
edited
Loading

Bug

Related to NuGet/Home#11676 and #4506

Regression? Last working version:

Description

This just removes some casts which aren't needed from #4506

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception - Existing tests cover this code path
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@dfederm dfederm requested a review from a team as a code owner March 23, 2022 00:06
@ghost ghost added the Community PRs created by someone not in the NuGet team label Mar 23, 2022
@dfederm
Copy link
Contributor Author

dfederm commented Mar 23, 2022

@jeffkl will be addressing this in a broader change son, so closing this PR

@dfederm dfederm closed this Mar 23, 2022
@dfederm dfederm deleted the sdkresolver-remove-casts branch March 23, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Community PRs created by someone not in the NuGet team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dfederm @kartheekp-ms