Ignore local sources when enforcing package source mapping with central package management #4764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
nkolev92
reviewed
Aug 23, 2022
nkolev92
previously approved these changes
Aug 29, 2022
…al package management
jeffkl
force-pushed
the
dev-jeffkl-ignore-local-sources-in-cpm-psm-warning
branch
from
df56320 to
50f1687
Compare
nkolev92
approved these changes
Aug 31, 2022
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11951
Regression? Last working version:
Description
Trim down configured sources to ones that are not local. Moved the logic inside of the check for package source mapping to avoid the overhead in case the user is already opt-ed in.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation