Skip failing E2E tests & fix missing method exception blocking CI #4768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
reviewed
Aug 25, 2022
nkolev92
approved these changes
Aug 26, 2022
Member
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
See comment about the issue reference in the test skip.
donnie-msft
changed the title
donnie-msft
added a commit
that referenced
this pull request
Aug 31, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12054
Fixes: NuGet/Home#12059
Regression? Last working version:
Description
Two blocking CI issues are addressed by this PR.
Skip E2E tests which are failing and blocking CI. Follow-up issue to investigate root cause: https://github.com/NuGet/Client.Engineering/issues/1826
For FuncTests failing: System.MissingMethodException Home#12059, I repro'd the issue locally, and debugging showed that the SxS MSBuild 17.04 assembly was being loaded (changed in https://www.nuget.org/packages/Microsoft.NET.StringTools/)
@nkolev92 found MSBuild with target netfx48 temp files present fails with Missing Method. dotnet/msbuild#7873 and that overriding this transitive for
System.Memory.dllresolves the issue.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation