Properly handle duplicate central package version items in the restore graph when using custom build ordering in a solution file #4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
nkolev92
reviewed
Aug 30, 2022
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Show resolved
Hide resolved
jeffkl
changed the title
nkolev92
reviewed
Aug 31, 2022
test/NuGet.Core.Tests/NuGet.Commands.Test/MSBuildRestoreUtilityTests.cs
Outdated
Show resolved
Hide resolved
nkolev92
previously approved these changes
Aug 31, 2022
jeffkl
force-pushed
the
dev-jeffkl-handle-duplicate-centralpackageversions
branch
from
5acf8a1 to
3906a1c
Compare
jeffkl
force-pushed
the
dev-jeffkl-handle-duplicate-centralpackageversions
branch
from
3906a1c to
c7f47b7
Compare
nkolev92
approved these changes
Aug 31, 2022
Member
nkolev92
left a comment
nkolev92
left a comment
There was a problem hiding this comment.
Thanks for adding that extra test!
martinrrm
approved these changes
Aug 31, 2022
jeffkl
deleted the
dev-jeffkl-handle-duplicate-centralpackageversions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12021
Regression? Last working version:
Description
When a user specified custom build ordering in a solution file, MSBuild generates a ProjectReference on the fly. If a user still has an actual ProjectReference in a project, NuGet will get the PackageReference and PackageVersions items twice with duplicates in the restore graph.
This updates the logic to handle duplicates by implementing a last one wins strategy.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation