Use DialogWindow directly from Microsoft.VisualStudio.PlatformUI #4778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
nkolev92
previously approved these changes
Aug 30, 2022
dominoFire
previously approved these changes
Aug 30, 2022
Contributor
dominoFire
left a comment
dominoFire
left a comment
There was a problem hiding this comment.
LGTM. Let's make sure we don't break anything by doing a quick FastPass Accessibility Insights test.
Contributor
Author
|
zivkan
previously approved these changes
Aug 31, 2022
donnie-msft
dismissed stale reviews from zivkan, dominoFire, and nkolev92
via
2370433
donnie-msft
force-pushed
the
dev-donnie-msft-removeVsDialogWindow
branch
from
be97b97 to
2370433
Compare
zivkan
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12065
Regression? Last working version:
Description
Remove VsDialogWindow.cs and the associated mentions in the
GlobalSuppressions.I see no differences in the control hierarchy before (left) and after (right) this change.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation