Removes unused string resources in nuget.exe #4779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
previously approved these changes
Aug 31, 2022
dominoFire
force-pushed
the
dev-dominofire-remove-nugetexe-unused-strings
branch
from
fa6e3b2 to
73b8abf
Compare
zivkan
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12066
Regression? No. Last working version: N/A
Description
Adds a missing string resource: Error_SourceProviderIsNull
Remove unused nuget.exe string resources listed below. Those strings were found after manually analyzing the remaining string resources found in this PR: #4773
NuGetResources.resx:
Warning_SymbolServerNotConfigured_*UnableToFindFile_*PushCommandPackagePushed_*NoApiKeyFound_*DeleteCommandDeletingPackage_*DeleteCommandDeletedPackage_*DeleteCommandCanceled_*DeleteCommandConfirm_*Error_SourceProviderIsNull_*NuGetCommands.resx:
InstallCommandDisableParallel_*InstallCommandNoCache_*InstallCommandSourceDescription_*RestoreCommandDisableParallelProcessing_*RestoreCommandNoCache_*RestoreCommandSourceDescription_*PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation