Extend default plugin timeouts per #11793 #4781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If this looks good, we should also apply to servicing branches. |
nkolev92
previously approved these changes
Sep 1, 2022
Member
|
Thanks for creating this PR @johnterickson It'd be great if you can reach out to Arturo for servicing considerations. |
Contributor
Author
|
@nkolev92 Could you reapprove now that I fixed the test regex? |
nkolev92
approved these changes
Sep 1, 2022
Contributor
Author
|
@nkolev92 Looks ready to merge. Anything else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11793
Regression? No
Description
Plugin timeout defaults are increased from 5 seconds to 30 seconds based on discussion in issue NuGet/Home#11793 and NuGet/Home#8528 (comment)
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation