Record telemetry if DTE or IVs API is used to get project properties #4785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Sep 2, 2022
....Clients/NuGet.PackageManagement.VisualStudio/Telemetry/VsProjectBuildPropertiesTelemetry.cs
Outdated
Show resolved
Hide resolved
jeffkl
approved these changes
Sep 3, 2022
nkolev92
reviewed
Sep 6, 2022
...Get.Clients/NuGet.PackageManagement.VisualStudio/ProjectServices/VsProjectBuildProperties.cs
Show resolved
Hide resolved
nkolev92
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1792
Regression? No
Description
Months ago, I wanted to fix a perf issue: #4421
However, since project systems have allow-lists of which properties they allow to be retrieved by different APIs, there's no guarantee that all project systems would work with that change. Therefore, this change adds telemetry which will give us confidence about how to fix the perf issue.
Added a singleton telemetry collector, which on VS close emits telemetry on which project system guids successfully returned property values from the two different APIs.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation