Adds special case to include transitive origins in GetInstalledAndTransitivePackagesAsync API #4824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominoFire
commented
Sep 27, 2022
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/ProjectView.xaml.cs
Outdated
Show resolved
Hide resolved
dominoFire
force-pushed
the
dev-dominofire-fixcache
branch
from
526de01 to
5c4cac3
Compare
erdembayar
reviewed
Sep 28, 2022
Contributor
erdembayar
left a comment
erdembayar
left a comment
There was a problem hiding this comment.
LGTM, just 2-3 comments.
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Projects/PackageReferenceProject.cs
Outdated
Show resolved
Hide resolved
...t.Clients.Tests/NuGet.PackageManagement.VisualStudio.Test/CpsPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
erdembayar
reviewed
Sep 28, 2022
src/NuGet.Clients/NuGet.PackageManagement.VisualStudio/Projects/PackageReferenceProject.cs
Outdated
Show resolved
Hide resolved
erdembayar
previously approved these changes
Sep 28, 2022
nkolev92
previously approved these changes
Sep 28, 2022
…ges but no transitive origins
Tests: Added 1 test Tests: Fixed test
… Package AND something else
Tests: Added more tests Tests: Reacommodated test Tests: Reverted test to ease reviewing Tests: Min-changeset
…s/PackageReferenceProject.cs Co-authored-by: Erick Yondon <[email protected]>
dominoFire
dismissed stale reviews from nkolev92 and erdembayar
via
c38583a
dominoFire
force-pushed
the
dev-dominofire-fixcache
branch
from
925f7df to
c38583a
Compare
erdembayar
approved these changes
Sep 29, 2022
AdmiringWorm
added a commit
to chocolatey/NuGet.Client
that referenced
this pull request
Dec 19, 2022
Insert 6.4.0-rc.123 into rel/d17.4 on 11/07/2022 23:47:12 * tag '6.4.0.123': (60 commits) fix a logic error that caused AbandonedMutexException while executing migrations (release-6.4.x) (NuGet#4895) unblock source build failing due to fatal: transport 'file' not allowed error (NuGet#4867) (NuGet#4874) Signing: update to August 2022 CTL (NuGet#4791) (NuGet#4850) Merged PR 422933: Prefer BCL Directory create API over helper class (7.0.1xx-rc2) Fix empty combobox when package is not present in project file (NuGet#4844) (NuGet#4848) Fix component detection alert for microsoft.owin package (NuGet#4841) (NuGet#4845) Make release label RC, move to escrow mode Adds special case to include transitive origins in GetInstalledAndTransitivePackagesAsync API (NuGet#4824) Add longPathAware manifest to NuGet.Build.Tasks.Console (NuGet#4830) VsPackageInstallerServices should not post ProjectNotNominatedException faults (NuGet#4814) Skip test GetOrCreateAsync_WithUnhandledExceptionInPlugin_Throws (NuGet#4831) Improve OptProf pipeline job run names (NuGet#4825) Increase HttpClientHandler.MaxConnectionsPerServer to 64 to improve PM UI performance in Visual Studio (NuGet#4798) Suppress CA2213 warnings to unblock dev branch (NuGet#4823) Ensure IsVsOfflineFeed is calculated correctly on 64-bit machines (NuGet#4817) Add better handling of AggregateExceptions in static graph-based restore (NuGet#4809) Add Component Detection task into each pipeline (NuGet#4813) Localizes nuget.exe with default, embedded resource assembly lookup (NuGet#4773) Removes BrowseObjectBase class in NuGet Solution Explorer (NuGet#4807) Improve TryCreateContext (NuGet#4762) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12102
Regression? Last working version: Yes, 17.3
Description
PackageSpecobjects. This way, we are ensuring we will show installed packages found in assets file.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation
Validation
Animations provided below to compare the effects of this PR.
Before
The bug appears during package installation in PM UI: transitive packages are not shown after installing a package with transitive dependencies.
After
Transitive packages appear after installing a package in PM UI.