Disable CPM for OptProf tests #5598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
approved these changes
Jan 16, 2024
kartheekp-ms
approved these changes
Jan 16, 2024
| @@ -1 +1,5 @@ | |||
| <Project /> | |||
Contributor
There was a problem hiding this comment.
May be the best option would have been to delete the Directory.Packages.props file completely because there are no properties defined in it.
Member
Author
There was a problem hiding this comment.
If you run the test from VS, or dotnet test on the CLI, I'm worried it might find the repo root Directory.Packages.props. I assume that's why the file was added in the first place. There are also empty Directory.Build.props and targets files in the same directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2656
Regression? yes Last working version: before #5572
Description
Explicitly disable CPM for OptProf test solution.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation