Skip to content

Conversation

atucom
Copy link
Contributor

@atucom atucom commented Mar 29, 2018

This PR includes the whitelist_wash() function, the cmdline argument, as well as the modification for the exploiter object call. If there is a more preferred way of implementing this feature, let me know. Currently it only works via cmdline, I'm planning on adding options to the interactive prompt next.

I originally thought of implementing this as a default file with its path specified in lib.settings (like the hosts file) but thought it would be better if it required the user to specify at run time.

@Ekultek
Copy link
Contributor

Ekultek commented Mar 29, 2018

I’m confused isn’t a whitelist suppose to be targets that you would not want to attack? Hence the name whitelist

@Ekultek
Copy link
Contributor

Ekultek commented Mar 29, 2018

Also, you missed adding the whitelist in the terminal prompts

@atucom
Copy link
Contributor Author

atucom commented Mar 29, 2018

Whitelist in this case would be like a character whitelist or pentest scope whitelist - a list of items allowed through, all others would be blocked.

Regarding the terminal prompts, I'm planning on adding that next.

@Ekultek
Copy link
Contributor

Ekultek commented Mar 29, 2018

Okay. I like it I’ll merge it once you get the whitelist added to the terminal, that way we can get it all done in one merge

@Ekultek Ekultek self-requested a review March 29, 2018 15:08
@Ekultek Ekultek added the enhancement New feature or request label Mar 29, 2018
@atucom
Copy link
Contributor Author

atucom commented Mar 29, 2018

Added

@Ekultek
Copy link
Contributor

Ekultek commented Mar 29, 2018

Here da399f4#diff-2b864a0c646b108a48e41ac008b31aa2R172

If a space is provided it will fail add an or not <var>.isspace()

@atucom
Copy link
Contributor Author

atucom commented Mar 29, 2018

Updated to include "and not whitelist_file.isspace():". "or not..." apparently broke it when supplied a space.

@Ekultek
Copy link
Contributor

Ekultek commented Mar 29, 2018

Merging

@Ekultek Ekultek merged commit 629332f into NullArray:dev-beta Mar 29, 2018
@atucom atucom deleted the feature-whitelist branch March 29, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants