Querying an Edm.Date property does not serialize correctly

[jnanneng]

Given the following entity definition:

 <Key>
      <PropertyRef Name="Id"/>
 </Key>
 <Property Name="Id" Type="Edm.Guid" Nullable="false"/>
 <Property Name="Value" Type="Edm.Date" Nullable="false"/>
 <Property Name="Value2" Type="Edm.Date"/>

Querying for a specific entity's data returns an Edm.Date as expected:
=> .../UnitTestDateTable(86e978ba-61d1-11e7-8501-3cd92b73d5f7)
{
@odata.context: ".../$metadata#UnitTestDateTable/$entity",
Id: "86e978ba-61d1-11e7-8501-3cd92b73d5f7",
Value: "1941-12-07",
Value2: "1943-09-19"
}

However when querying for an Edm.Date property (Value) does not return as expected:
=> .../UnitTestDateTable(86e978ba-61d1-11e7-8501-3cd92b73d5f7)/Value
{
@odata.context: ".../$metadata#UnitTestDateTable(86e978ba-61d1-11e7-8501-3cd92b73d5f7)/Value",
value: "1941-12-07T00:00:00-06:00"
}

Expected "1941-12-07" but actually returns "1941-12-07T00:00:00-06:00" [looks like a DateTimeOffset value].

This is further a problem when using the ODataMessageReader to "ReadProperty()" which throws an exception:

An exception of type 'Microsoft.OData.Core.ODataException' occurred in Microsoft.OData.Core.dll but was not handled in user code

Additional information: Cannot convert the literal '1941-12-07T00:00:00-06:00' to the expected type 'Edm.Date'.

[xuzhg]

I had a simple test as follows CLR model:

public class Customer
{
   public int Id { get; set; }
   public Date? DateValue { get; set; }
   public Date DateValue2 { get; set; }
}

To build the model as:

private IEdmModel GetEdmModel()
{
   var builder = new ODataConventionModelBuilder();
   builder.EntitySet<Customer>("Customers");
   return builder.GetEdmModel();
 }

Controller is like:

public class CustomersController : ODataController
{
    public IHttpActionResult Get(int key)
    {
        return Ok(new Customer { Id = key, DateValue = new Date(2017, 2, 2), DateValue2 = new Date(1089, 2, 19) });
    }

    public IHttpActionResult GetDateValue(int key)
    {
        return Ok(new Date(2017, 8, 25));
    }

    public IHttpActionResult GetDateValue2(int key)
    {
        return Ok(new Date(1978, 12, 12));
    }
}

When I query the request as:

~/odata/$metadata
~/odata/Customers
~/odata/Customers(1)/DateValue
~/odata/Customers(1)/DateValue2

I get:

<?xml version="1.0" encoding="utf-8"?>
<edmx:Edmx Version="4.0" xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx">
  <edmx:DataServices>
    <Schema Namespace="ODataLibReader" xmlns="http://docs.oasis-open.org/odata/ns/edm">
      <EntityType Name="Customer">
        <Key>
          <PropertyRef Name="Id" />
        </Key>
        <Property Name="Id" Type="Edm.Int32" Nullable="false" />
        <Property Name="DateValue" Type="Edm.Date" />
        <Property Name="DateValue2" Type="Edm.Date" Nullable="false" />
      </EntityType>
    </Schema>
    <Schema Namespace="Default" xmlns="http://docs.oasis-open.org/odata/ns/edm">
      <EntityContainer Name="Container">
        <EntitySet Name="Customers" EntityType="ODataLibReader.Customer" />
      </EntityContainer>
    </Schema>
  </edmx:DataServices>
</edmx:Edmx>

{"@odata.context":"http://localhost/odata/$metadata#Customers/$entity","Id":1,"DateValue":"2017-02-02","DateValue2":"1089-02-19"}

{"@odata.context":"http://localhost/odata/$metadata#Customers(1)/DateValue","value":"2017-08-25"}

{"@odata.context":"http://localhost/odata/$metadata#Customers(1)/DateValue2","value":"1978-12-12"}

It seems work fine at my side.

@jnanneng Would you please take a look at your side?

[jnanneng]

Thank you for looking into this. In my particular scenario, the CLR model use's .NET's DateTime datatype. (I'm sharing the CLR model between OData V3 and OData V4). On a 'Date' property, I add a System.ComponentModel.DataAnnotations.Schema.ColumnAttribute with its 'TypeName' set to 'date'. This then gets picked up by Web API's OData V4 ColumnAttributeEdmPropertyConvention which then uses an EDM Date in lieu of the CLR DateTime... Doing so should repo the situation...

[xuzhg]

@jnanneng Ok. I will take a look.