Conversation
|
Although this has a moderate amount of subjectivity, not every change improves readability. In fact it can make it worse. For example this: response = "";
// or this:
binOptList["-O"] = "";With no context tells me that However this: response.clear();
// or this:
binOptList["-O"].clear();Doesn't tell me anything. These variables could be a vector, a map, a list, a string, a custom class. Without an IDE and further reading I can't tell. Is There are cases such as in OgreScriptLexer.cpp where the change may likely result in higher performance, and it is a place where performance is important, hence the change is welcome. Likewise in Now I can extract some of these changes selectively from your PR and merge them manually; so that we can debate the rest. |
|
@darksylinc, |
3904aa1 to
da6dbf9
Compare
76d820e to
03fbfb6
Compare
2ee1c83 to
8b3ddcc
Compare
49c451d to
84c07a0
Compare
a3c7671 to
67f9fdd
Compare
@darksylinc minor changes affect readability code, but
clear()function cleans string correctly