Skip to content

Conversation

@Niweera
Copy link
Contributor

@Niweera Niweera commented Jan 30, 2021

This pull request is regarding issue #132.

Work done

  1. Added CodeQLReader as a new parser for parsing the CodeQL results (SARIF) file.
  2. Updated BenchmarkScore to identify a given SARIF results file that belongs to either LGTM or CodeQL.

Update BenchmarkScore to identify whether the provided SARIF file belongs to CodeQL or LGTM
@davewichers davewichers merged commit 40c5a68 into OWASP-Benchmark:master Jan 30, 2021
@davewichers
Copy link
Contributor

@Niweera @Moose0621 - In case either of you care, I checked in a new version of the CodeQLReader that adds a manual mapping method of CodeQL CWEs to CWEs expected by Benchmark. This resulted in a proper mapping of 1 RandomNumber generation rule, so now CodeQL gets proper credit for detecting Weak Random number generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants