Added two configurations for commercial IAST tools. #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
hi Grant may i understand from you, why are you editing the source file "CheckmarxIASTReader.java" ? |
Contributor
Author
|
Hi Jason,
I didn't actually. I added that file myself (it didn't exist in the repo
when I initially pulled it) but it seems that someone else also added it?
Best regards,
Grant
…On Mon, 9 Mar 2020 at 02:16, Jason Khoo ***@***.***> wrote:
hi Grant
may i understand from you, why are you editing the source file
"CheckmarxIASTReader.java" ?
thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/OWASP/Benchmark/pull/99?email_source=notifications&email_token=ABORWTYMQ3UTXPQS4HL6BE3RGRGOZA5CNFSM4LDUDCR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOFNMWI#issuecomment-596301401>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABORWT3Z7JBN3GUPS5N6CNDRGRGOZANCNFSM4LDUDCRQ>
.
|
Contributor
|
Grant, these look like excellent contributions. Thank you. However you and Jason both contributed a CheckmarxIASTReader. Can you resolve the conflict with that file, and BenchmarkScore, so I can just click/accept your additions/changes? |
Contributor
Author
|
Conflicts resolved in consultation with @cx-jason |
Fix formatting in changed lines to match original file. Delete duplicate code added accidentally for parsing .faast files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the config required for the commercial IAST tools Seeker and CxIAST (without adding their actual code to the repository).