Improper type check in ExchangeService.bindToItem()

[Noblebrown]

In ExchangeService.bindToItem() (line 1428, currently), the parameter Class is passed. The method uses the generic bindToItem() to retrieve an item, then does a type check and cast down to TItem. However, the type check is:

if (result instanceof Item)

This is incorrect as we already know it's an item. It should be type checking against Class.

[vboctor]

How about the following?

protected <TItem extends Item> TItem bindToItem(Class<TItem> c,
        ItemId itemId, PropertySet propertySet) throws Exception {
    Item result = this.bindToItem(itemId, propertySet);
    if (c.isAssignableFrom(result.getClass())) {
        return (TItem) result;
    } else {
        throw new ServiceLocalException(String.format(
                Strings.ItemTypeNotCompatible, result.getClass().getName(),
                c.getName()));
    }
}