Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Conversation

@ahaarrestad
Copy link
Contributor

See #165 and #169 for discussion.

@azurecla
Copy link

Hi @ahaarrestad, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@ahaarrestad
Copy link
Contributor Author

@serious6 @evpaassen new PR created.

@evpaassen evpaassen mentioned this pull request Jan 15, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method shouldn't be exposed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default protected. alternative is private, which probably is ok

@ahaarrestad
Copy link
Contributor Author

Updated as commented.

@ahaarrestad
Copy link
Contributor Author

merge-time?

@ahaarrestad
Copy link
Contributor Author

Improved solution in #176

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants