Skip to content

Window manager BadTokenException / WindowLeaked #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Window manager BadTokenException / WindowLeaked #2208

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0ab9c8
simulate WindowLeak exception
jinliu9508 Oct 30, 2024
95b0d90
check activity availability before showing a dialog
jinliu9508 Oct 30, 2024
df65bae
clean up
jinliu9508 Oct 30, 2024
e5db933
fix up: use try and catch and fire onDecline callback
jinliu9508 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions ...in/java/com/onesignal/core/internal/permissions/AlertDialogPrepromptForAndroidSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ package com.onesignal.core.internal.permissions

import android.app.Activity
import android.app.AlertDialog
import android.view.WindowManager.BadTokenException
import com.onesignal.core.R
import com.onesignal.debug.LogLevel
import com.onesignal.debug.internal.logging.Logging

/**
* A singleton helper which will display the fallback-to-settings alert dialog.
Expand All @@ -53,18 +56,26 @@ object AlertDialogPrepromptForAndroidSettings {
val messageTemplate = activity.getString(R.string.permission_not_available_message)
val message = messageTemplate.format(previouslyDeniedPostfix)

AlertDialog.Builder(activity)
.setTitle(title)
.setMessage(message)
.setPositiveButton(R.string.permission_not_available_open_settings_option) { dialog, which ->
callback.onAccept()
}
.setNegativeButton(android.R.string.no) { dialog, which ->
callback.onDecline()
}
.setOnCancelListener {
callback.onDecline()
}
.show()
// Try displaying the dialog while handling cases where execution is not possible.
try {
AlertDialog.Builder(activity)
.setTitle(title)
.setMessage(message)
.setPositiveButton(R.string.permission_not_available_open_settings_option) { dialog, which ->
callback.onAccept()
}
.setNegativeButton(android.R.string.no) { dialog, which ->
callback.onDecline()
}
.setOnCancelListener {
callback.onDecline()
}
.show()
} catch (ex: BadTokenException) {
// If Android is unable to display the dialog, trigger the onDecline callback to maintain
// consistency with the behavior when the dialog is canceled or dismissed without a response.
Logging.log(LogLevel.ERROR, "Alert dialog for Android settings was skipped because the activity was unavailable to display it.")
callback.onDecline()
}
}
}
Loading