Skip to content

Fix: Notification click not foreground the app in the first click if app is closed and no clickListener is added #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Fix: Notification click not foreground the app in the first click if app is closed and no clickListener is added #2259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94df4b9
refactor: Split IBootstrapService to a new file and update comments
jinliu9508 Feb 20, 2025
e2b793b
fix: make InAppMessagePreviewHandler to a Bootstrap service instead o…
jinliu9508 Feb 20, 2025
f5cde9a
fix default canOpen to true
jinliu9508 Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: make InAppMessagePreviewHandler to a Bootstrap service instead o… 
…f a Startable service
  • Loading branch information
@jinliu9508
jinliu9508 committed Feb 24, 2025
commit e2b793b1c4e191d59e631fb5b2f4ca1369a3f312
3 changes: 2 additions & 1 deletion ...nesignal/in-app-messages/src/main/java/com/onesignal/inAppMessages/InAppMessagesModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.onesignal.inAppMessages
import android.os.Build
import com.onesignal.common.modules.IModule
import com.onesignal.common.services.ServiceBuilder
import com.onesignal.core.internal.startup.IBootstrapService
import com.onesignal.core.internal.startup.IStartableService
import com.onesignal.inAppMessages.internal.DummyInAppMessagesManager
import com.onesignal.inAppMessages.internal.InAppMessagesManager
Expand Down Expand Up @@ -50,7 +51,7 @@ internal class InAppMessagesModule : IModule {
builder.register<InAppDisplayer>().provides<IInAppDisplayer>()

// Previews
builder.register<InAppMessagePreviewHandler>().provides<IStartableService>()
builder.register<InAppMessagePreviewHandler>().provides<IBootstrapService>()

// Prompts
builder.register<InAppMessagePromptFactory>().provides<IInAppMessagePromptFactory>()
Expand Down
6 changes: 3 additions & 3 deletions .../src/main/java/com/onesignal/inAppMessages/internal/preview/InAppMessagePreviewHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package com.onesignal.inAppMessages.internal.preview

import android.app.Activity
import com.onesignal.core.internal.application.IApplicationService
import com.onesignal.core.internal.startup.IStartableService
import com.onesignal.core.internal.startup.IBootstrapService
import com.onesignal.core.internal.time.ITime
import com.onesignal.inAppMessages.internal.display.IInAppDisplayer
import com.onesignal.inAppMessages.internal.state.InAppStateService
Expand All @@ -25,8 +25,8 @@ internal class InAppMessagePreviewHandler(
private val _notificationLifeCycle: INotificationLifecycleService,
private val _state: InAppStateService,
private val _time: ITime,
) : IStartableService, INotificationLifecycleCallback {
override fun start() {
) : IBootstrapService, INotificationLifecycleCallback {
override fun bootstrap() {
_notificationLifeCycle.setInternalNotificationLifecycleCallback(this)
}

Expand Down