Skip to content

Fix: NotificationOpenedActivity "freeze" when a large amount of notification is clicked #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025
Merged

Fix: NotificationOpenedActivity "freeze" when a large amount of notification is clicked #2304

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef2286a
refactor: move mocks to a mock object for NotificaationLifecycleServi…
jinliu9508 May 20, 2025
54c0fd1
test: add a test unit to ensure openDestinationActivity not to be blo…
jinliu9508 May 22, 2025
817a9cf
fix: call updateNotificationAsOpened in a destinate coroutine scope
jinliu9508 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: call updateNotificationAsOpened in a destinate coroutine scope
  • Loading branch information
@jinliu9508
jinliu9508 committed May 22, 2025
commit 817a9cfe6269617a6636410f95c7f74ca2fe73e9
21 changes: 12 additions & 9 deletions .../java/com/onesignal/notifications/internal/lifecycle/impl/NotificationLifecycleService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import com.onesignal.common.JSONUtils
import com.onesignal.common.events.CallbackProducer
import com.onesignal.common.events.EventProducer
import com.onesignal.common.exceptions.BackendException
import com.onesignal.common.threading.OSPrimaryCoroutineScope
import com.onesignal.core.internal.application.AppEntryAction
import com.onesignal.core.internal.application.IApplicationService
import com.onesignal.core.internal.config.ConfigModelStore
Expand Down Expand Up @@ -138,15 +139,17 @@ internal class NotificationLifecycleService(

postedOpenedNotifIds.add(notificationId)

try {
_backend.updateNotificationAsOpened(
appId,
notificationId,
subscriptionId,
deviceType,
)
} catch (ex: BackendException) {
Logging.error("Notification opened confirmation failed with statusCode: ${ex.statusCode} response: ${ex.response}")
OSPrimaryCoroutineScope.execute {
try {
_backend.updateNotificationAsOpened(
appId,
notificationId,
subscriptionId,
deviceType,
)
} catch (ex: BackendException) {
Logging.error("Notification opened confirmation failed with statusCode: ${ex.statusCode} response: ${ex.response}")
}
}
}

Expand Down
Loading