Skip to content

Conversation

@jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented May 22, 2025

Description

One Line Summary

Check whether the WindowInsets is null before calling its method.

Details

Motivation

Fix a NPE crash when a view is detached while evaluating IAMs.

Testing

Unit testing

No unit test is added; test not needed

Manual testing

Tested on a Pixel 9 API 35 emulator only with basic functionalities. I am not able to reproduce the scenario when WindowInsets is null. The code will return false when that happens.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jinliu9508 jinliu9508 merged commit 875dac5 into main May 22, 2025
2 checks passed
@jinliu9508 jinliu9508 deleted the npe-window-insets branch May 22, 2025 19:02
@jinliu9508 jinliu9508 mentioned this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants