Skip to content

fix: push subscription observers not firing #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

fix: push subscription observers not firing #2330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../core/src/main/java/com/onesignal/user/internal/subscriptions/impl/SubscriptionManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,14 @@ internal class SubscriptionManager(
model: SubscriptionModel,
tag: String,
) {
// Do not remove the push subscription: we need to keep the existing push subscription and its observers
// This push subscription will immediately be replaced by the new one in the [onModelAdded] event
// The [onModelRemoved] event for a push subscription model should always be followed by a [onModelAdded]
// event with a new push subscription model. On 404s, no push subscription models are removed.
if (model.type == SubscriptionType.PUSH) {
return
}

val subscription = subscriptions.collection.firstOrNull { it.id == model.id }

if (subscription != null) {
Expand Down
Loading