Skip to content

Conversation

@jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jun 30, 2025

Description

One Line Summary

Removed noisy logging "Already instantiated" and "Found constructor" that has never been useful.

Details

Also corrected "Constructor X could not find service" to be errors instead of debug.

Motivation

These extra logs always got in the way with 100s of entries and we never ever used them. This is also expected to give a very small, but still probably measurable, initialization performance improvement.

Scope

No logic changes, only effects logging of the ServiceProvider

Testing

Unit testing

No tests covering these logs to remove.

Manual testing

Tested on a Android 9 emulator.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Removed noisy logging "Already instantiated" and "Found constructor"
that has never been useful.
Corrected "Constructor X could not find service" to be errors instead
of debug.
@jkasten2 jkasten2 force-pushed the logs-clean-up-from-service-provider branch from 998b451 to 6979463 Compare June 30, 2025 17:42
Copy link
Contributor

@jinliu9508 jinliu9508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that these logs are not useful at all.

Base automatically changed from main-gradle8-and-central-portal to main June 30, 2025 20:25
@jkasten2 jkasten2 merged commit 4e99955 into main Jun 30, 2025
2 checks passed
@jkasten2 jkasten2 deleted the logs-clean-up-from-service-provider branch June 30, 2025 20:25
@jkasten2 jkasten2 mentioned this pull request Jun 30, 2025
nan-li pushed a commit that referenced this pull request Jul 8, 2025
…ovider

Clean up logging from ServiceProvider
@nan-li nan-li mentioned this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants