Skip to content

OSConsistencyManager & IAM fetch read-your-write consistency implementation #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 23, 2024
Merged

OSConsistencyManager & IAM fetch read-your-write consistency implementation #1486

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fa3c750
OSReadYourWriteData Implementation
Oct 18, 2024
eb45946
OSConsistencyManager & related classes
Sep 10, 2024
05d327d
IamFetch consistency use-case implementation
Sep 10, 2024
6f40409
Update project.pbxproj
Sep 10, 2024
b07df39
Move `getTimeFocusedElapsed` from `OneSignalTracker` to `OSSessionMan…
Sep 17, 2024
e7d65f6
Modify `OSRequestGetInAppMessages` method to include new header values
Sep 17, 2024
9ac1053
OSMessagingController Retry Logic
Sep 17, 2024
d09d464
Update executors to set offsets on consistency manager
Sep 17, 2024
924d8a1
Flush delta queue on start
Sep 17, 2024
b8aeed2
Update UnitTestApp TestPlan xctestplan
Oct 3, 2024
82e468b
Update OSIamFetchReadyCondition to sharedInstance to waist on sub update
Oct 9, 2024
4f7a9dd
Update OneSignalClient to include headers
Oct 9, 2024
663edc1
Run swiftlint --fix
Oct 23, 2024
75eab0f
Clarifying comment re: why we track RYW tokens for user create as well
Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarifying comment re: why we track RYW tokens for user create as well 
Motivation: On fresh installs, we don't yet have a user or a subscription to update so we wouldn't get a RYW token until those requests are executed (5 seconds later when the operations are processed)
  • Loading branch information
Rodrigo Gomez Palacio committed Oct 23, 2024
commit 75eab0f355d5ad281fb5e675d3e7ac4210d54db3
3 changes: 3 additions & 0 deletions iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/Consistency/IamFetch/OSIamFetchOffsetKey.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
import Foundation

public enum OSIamFetchOffsetKey: Int, OSConsistencyKeyEnum {
// We track user create tokens as well because on fresh installs, we don't have a user or subscription
// to update, which would lead to a 5 second delay until the subsequent user & subscription update calls
// give us RYW tokens
case userCreate = 0
case userUpdate = 1
case subscriptionUpdate = 2
Expand Down
3 changes: 3 additions & 0 deletions ...K/OneSignalSDK/OneSignalOSCore/Source/Consistency/IamFetch/OSIamFetchReadyCondition.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
public func isMet(indexedTokens: [String: [NSNumber: OSReadYourWriteData]]) -> Bool {
guard let tokenMap = indexedTokens[id] else { return false }

// We track user create tokens as well because on fresh installs, we don't have a user or subscription
// to update, which would lead to a 5 second delay until the subsequent user & subscription update calls
// give us RYW tokens
let userCreateTokenSet = tokenMap[NSNumber(value: OSIamFetchOffsetKey.userCreate.rawValue)] != nil
let userUpdateTokenSet = tokenMap[NSNumber(value: OSIamFetchOffsetKey.userUpdate.rawValue)] != nil
let subscriptionTokenSet = tokenMap[NSNumber(value: OSIamFetchOffsetKey.subscriptionUpdate.rawValue)] != nil
Expand Down
Loading