Skip to content

fix(badges): drop deprecated applicationIconBadgeNumber usage #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 29, 2025
Merged

fix(badges): drop deprecated applicationIconBadgeNumber usage #1568

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fe3148
clearBadgeCount method does not need to return bool
nan-li May 27, 2025
208ff4e
Centralize method to cache badge count
nan-li May 28, 2025
5114281
nit: remove unused method from OneSignalExtensionBadgeHandler header
nan-li May 28, 2025
6d9b74c
Use new setBadgeCount API on iOS 16+
nan-li May 27, 2025
0f1ae55
Remove all usages of deprecated applicationIconBadgeNumber
nan-li May 28, 2025
1fe4fc1
Keep a previous badge count as well as current
nan-li May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
nit: remove unused method from OneSignalExtensionBadgeHandler header 
* currentCachedBadgeValue is only used within the OneSignalExtensionBadgeHandler class, no need to expose on header.
  • Loading branch information
@nan-li
nan-li committed May 28, 2025
commit 5114281f54d398bcaf5fa3a61b2fe9e4e67c34c4
1 change: 0 additions & 1 deletion iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalExtensionBadgeHandler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,4 @@

@interface OneSignalExtensionBadgeHandler : NSObject
+ (void)handleBadgeCountWithNotificationRequest:(UNNotificationRequest *)request withNotification:(OSNotification *)notification withMutableNotificationContent:(UNMutableNotificationContent *)replacementContent;
+ (NSInteger)currentCachedBadgeValue;
@end