Skip to content

Conversation

@eriktim
Copy link
Contributor

@eriktim eriktim commented Oct 1, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master (3.3.x), 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

@wing328 Fixed a bug. Would be great to have in 3.3.0 as well.

@eriktim eriktim added this to the 3.3.0 milestone Oct 1, 2018
@wing328
Copy link
Member

wing328 commented Oct 1, 2018

Ok. Looks good to me. All tests passed as well.

@wing328 wing328 merged commit dcc0b5e into OpenAPITools:master Oct 1, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants