Skip to content

[python-experimental] Allow response media types to omit schema #12135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacether merged 10 commits into from
Apr 13, 2022
Merged

[python-experimental] Allow response media types to omit schema #12135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
66da49c
Adds issue spec file and attemts to generate code from it
spacether Apr 12, 2022
7a7fd2d
Adds missing schema definitions
spacether Apr 12, 2022
0309aa4
Skips fromProperty invocation if the passed in schema is none in getC…
spacether Apr 13, 2022
8a18944
Makes MediaType.schema optional
spacether Apr 13, 2022
2454205
Adds checking that the content type is in self.content
spacether Apr 13, 2022
8655d1c
Sets ApiResponse body type as Unset if there is no schema for it
spacether Apr 13, 2022
d6cd2d7
Handles schema = None case
spacether Apr 13, 2022
b656a02
Adds endpoint without response schema
spacether Apr 13, 2022
9365758
Reverts version files
spacether Apr 13, 2022
abd486d
Adds test_response_without_schema
spacether Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Makes MediaType.schema optional
  • Loading branch information
@spacether
spacether committed Apr 13, 2022
commit 8a18944d5e03319e8cca5ab3ec8452e20cbe1e3b
11 changes: 3 additions & 8 deletions modules/openapi-generator/src/main/resources/python-experimental/api_client.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,7 @@ class Encoding:
self.allow_reserved = allow_reserved


@dataclass
class MediaType:
"""
Used to store request and response body schema information
Expand All @@ -682,14 +683,8 @@ class MediaType:
The encoding object SHALL only apply to requestBody objects when the media type is
multipart or application/x-www-form-urlencoded.
"""

def __init__(
self,
schema: typing.Type[Schema],
encoding: typing.Optional[typing.Dict[str, Encoding]] = None,
):
self.schema = schema
self.encoding = encoding
schema: typing.Optional[typing.Type[Schema]] = None
encoding: typing.Optional[typing.Dict[str, Encoding]] = None


@dataclass
Expand Down
11 changes: 3 additions & 8 deletions samples/openapi3/client/petstore/python-experimental-issue-11763/petstore_api/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ def __init__(
self.allow_reserved = allow_reserved


@dataclass
class MediaType:
"""
Used to store request and response body schema information
Expand All @@ -687,14 +688,8 @@ class MediaType:
The encoding object SHALL only apply to requestBody objects when the media type is
multipart or application/x-www-form-urlencoded.
"""

def __init__(
self,
schema: typing.Type[Schema],
encoding: typing.Optional[typing.Dict[str, Encoding]] = None,
):
self.schema = schema
self.encoding = encoding
schema: typing.Optional[typing.Type[Schema]] = None
encoding: typing.Optional[typing.Dict[str, Encoding]] = None


@dataclass
Expand Down