Skip to content

[python-experimental] fixes bug where some singleton representations raised a RecursionError #12157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spacether merged 7 commits into from
Apr 17, 2022
Merged

[python-experimental] fixes bug where some singleton representations raised a RecursionError #12157

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
061e867
Adds issue components and endpoint
spacether Apr 17, 2022
a89a768
Regenerates samples
spacether Apr 17, 2022
545759a
Fixes singleton repr, removes issue components and endpoint
spacether Apr 17, 2022
76d6bad
Removes unused endpoint
spacether Apr 17, 2022
114552f
Reverts file
spacether Apr 17, 2022
1ea47d4
Adds tests of enum, boolean, and none representations
spacether Apr 17, 2022
7383c97
Uses super repr for singletons that ere not none, true, or false
spacether Apr 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds tests of enum, boolean, and none representations
  • Loading branch information
@spacether
spacether committed Apr 17, 2022
commit 1ea47d4fcae13e2c4c949c35a0f53e5b4f5a6452
6 changes: 3 additions & 3 deletions samples/openapi3/client/petstore/python-experimental/tests_manual/test_boolean_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"""


import sys
import unittest

import petstore_api
Expand All @@ -28,9 +27,10 @@ def tearDown(self):

def test_BooleanEnum(self):
"""Test BooleanEnum"""
# FIXME: construct object with mandatory attributes with example values
model = BooleanEnum(True)
model is BooleanEnum.TRUE
# TODO why is BooleanEnum.TRUE.__class__ DynamicDynamicBooleanEnum? It should only have one Dynamic
# assert model is BooleanEnum.TRUE
assert repr(model) == '<DynamicBooleanEnum: True>'
with self.assertRaises(petstore_api.ApiValueError):
BooleanEnum(False)

Expand Down
2 changes: 1 addition & 1 deletion samples/openapi3/client/petstore/python-experimental/tests_manual/test_nullable_string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"""


import sys
import unittest

import petstore_api
Expand All @@ -34,6 +33,7 @@ def testNullableString(self):
assert isinstance(inst, NullableString)
assert isinstance(inst, Schema)
assert inst.is_none() is True
assert repr(inst) == '<DynamicNullableString: None>'

inst = NullableString('approved')
assert isinstance(inst, NullableString)
Expand Down
3 changes: 2 additions & 1 deletion samples/openapi3/client/petstore/python-experimental/tests_manual/test_string_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"""


import sys
import unittest

import petstore_api
Expand All @@ -32,12 +31,14 @@ def testStringEnum(self):
inst = StringEnum(None)
assert isinstance(inst, StringEnum)
assert isinstance(inst, NoneClass)
assert repr(inst) == '<DynamicStringEnum: None>'

inst = StringEnum('approved')
assert isinstance(inst, StringEnum)
assert isinstance(inst, Singleton)
assert isinstance(inst, str)
assert inst == 'approved'
assert repr(inst) == '<DynamicStringEnum: approved>'

with self.assertRaises(petstore_api.ApiValueError):
StringEnum('garbage')
Expand Down