-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[dart-dio] [dart] Unify both dart generators into just dart
#14346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ahmednfwela
wants to merge
22
commits into
OpenAPITools:master
from
Bdaya-Dev:dart-dio/optional-http-library
Closed
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
139bcfb
override createDiscriminator
ahmednfwela a410925
assign discriminator = null to remove duplicates
ahmednfwela 91acb72
added discriminatorValue extension
ahmednfwela db5c229
added _defaults
ahmednfwela 0d00861
formatting
ahmednfwela d2bf302
samples
ahmednfwela 8f3b24b
use gitter instead
ahmednfwela f471c1b
remove comment
ahmednfwela b401182
updated samples
ahmednfwela 7b6d235
revert formatting changes
ahmednfwela 51ca294
update samples
ahmednfwela 7b74fc9
change file permissions
ahmednfwela 43cc795
Merge branch 'master' of github.com:OpenAPITools/openapi-generator in…
ahmednfwela ffeed66
WIP initial commit
ahmednfwela 35d234a
remove EXPERIMENTAL from readme
ahmednfwela 717127f
remove old samples
ahmednfwela 3cf1790
add echo api
ahmednfwela d5bbc07
added more configs
ahmednfwela fc95ab7
update samples
ahmednfwela 6753ef8
fixed empty vars case in json_serializable
ahmednfwela 939175f
WIP
ahmednfwela c8ba048
Merge branch 'master' of github.com:OpenAPITools/openapi-generator in…
ahmednfwela File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| generatorName: dart-dio | ||
| outputDir: samples/client/echo_api/dart/dart-dio-built_value | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/dart/echo_api.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/dart/libraries/dio | ||
| typeMappings: | ||
| Client: "ModelClient" | ||
| File: "ModelFile" | ||
| EnumClass: "ModelEnumClass" | ||
| additionalProperties: | ||
| hideGenerationTimestamp: "true" | ||
| enumUnknownDefaultCase: "true" | ||
| serializationLibrary: "built_value" | ||
| networkingLibrary: "dio" | ||
| artifactId: echo-api-dart-dio-built_value | ||
| reservedWordsMappings: | ||
| class: "classField" | ||
|
|
||
|
|
||
18 changes: 18 additions & 0 deletions
18
bin/configs/dart-dio-echo-server-dio-json_serializable.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| generatorName: dart-dio | ||
| outputDir: samples/client/echo_api/dart/dart-dio-json_serializable | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/dart/echo_api.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/dart/libraries/dio | ||
| typeMappings: | ||
| Client: "ModelClient" | ||
| File: "ModelFile" | ||
| EnumClass: "ModelEnumClass" | ||
| additionalProperties: | ||
| hideGenerationTimestamp: "true" | ||
| enumUnknownDefaultCase: "true" | ||
| serializationLibrary: "json_serializable" | ||
| networkingLibrary: "dio" | ||
| artifactId: echo-api-dart-dio-json_serializable | ||
| reservedWordsMappings: | ||
| class: "classField" | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| generatorName: dart-dio | ||
| outputDir: samples/client/echo_api/dart/dart-http-built_value | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/dart/echo_api.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/dart/libraries/dio | ||
| typeMappings: | ||
| Client: "ModelClient" | ||
| File: "ModelFile" | ||
| EnumClass: "ModelEnumClass" | ||
| additionalProperties: | ||
| hideGenerationTimestamp: "true" | ||
| enumUnknownDefaultCase: "true" | ||
| serializationLibrary: "built_value" | ||
| networkingLibrary: "http" | ||
| artifactId: echo-api-dart-http-built_value | ||
| reservedWordsMappings: | ||
| class: "classField" | ||
|
|
18 changes: 18 additions & 0 deletions
18
bin/configs/dart-dio-echo-server-http-json_serializable.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| generatorName: dart-dio | ||
| outputDir: samples/client/echo_api/dart/dart-http-json_serializable | ||
| inputSpec: modules/openapi-generator/src/test/resources/3_0/dart/echo_api.yaml | ||
| templateDir: modules/openapi-generator/src/main/resources/dart/libraries/dio | ||
| typeMappings: | ||
| Client: "ModelClient" | ||
| File: "ModelFile" | ||
| EnumClass: "ModelEnumClass" | ||
| additionalProperties: | ||
| hideGenerationTimestamp: "true" | ||
| enumUnknownDefaultCase: "true" | ||
| serializationLibrary: "json_serializable" | ||
| networkingLibrary: "http" | ||
| artifactId: echo-api-dart-dio-json_serializable | ||
| reservedWordsMappings: | ||
| class: "classField" | ||
|
|
||
|
|
11 changes: 0 additions & 11 deletions
11
bin/configs/dart-dio-oneof-polymorphism-and-inheritance.yaml
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using
library(global option, not generator option) instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently the
serializationLibraryis assigned tolibraryglobal option (this was introduced in #9980)I was going to make another PR that targets v7.0.0, with the correct parameters assigned, but I am not sure if this is the right approach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relevant line: https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/DartDioClientCodegen.java#L162