Fix Bug with decimal literal in C# #1436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 25, 2018 09:27
Bring my fork up to date with base
Catch up to mothership
Member
|
cc @OpenAPITools/generator-core-team as the change impacts ModelUtils class. |
wing328
reviewed
Jan 25, 2019
| return p.getDefault().toString() + "D"; | ||
| } else { | ||
| return p.getDefault().toString(); | ||
| } else { // decimal |
Contributor
Author
There was a problem hiding this comment.
Thanks, should be GTG now.
PS: I'll be back to this project pretty soon, just got assigned to some other stuff for a while. I appreciate you keeping my PR moving.
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…s#1436) * Trivial change to kick PR again * Fix issue 1433 (default decimal literal broken for C#) * Replace tab with space * update samples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.@mandrean @jimschubert
Description of the PR
Fixes #1433