Add nullable support to C# client (refactor) #1775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimschubert
reviewed
Dec 30, 2018
|
|
||
| @Override | ||
| public void processOpts() { | ||
| // mapped non-nullable type without ? |
Member
There was a problem hiding this comment.
I think this block has to go into the constructor. Otherwise, the user won't be able to override types for things like DateTime, array, list, and map.
Member
|
Scanning this looks good. I had one small comment. I'll need to run the code at a later point, though. |
Member
Author
Feel free to do it later. I'll merge it for the time being so that users can try it with 4.0.0-beta release. |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* add nullable support to c# client (refactor) * clean up methods * move typemapping to constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Add support for nullable parameters and properties in the C# client (refactor)
cc @mandrean (2017/08) @jimschubert (2017/09)