Deprecated initialCaps #1821
Merged
Deprecated initialCaps #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osharav
reviewed
Feb 13, 2019
| @SuppressWarnings("static-method") | ||
| public String initialCaps(String name) { | ||
| return StringUtils.capitalize(name); | ||
| return camelize(name); |
Contributor
There was a problem hiding this comment.
camelize removes underscores which may cause issues with the InlineModelResolver and other places where underscores are being introduced. in the cpp rest sdk client generator this causes the class names to be different than the file names (some method calls have used initialCaps and some have not) which causes import errors.
I will open a dedicated issue for this.
Regards,
Omer.
Member
Author
There was a problem hiding this comment.
Yes, please open a separate issue with a (minimal) spec to reproduce the issue.
Contributor
|
#2003 could be related |
Member
Author
Contributor
|
True, but I have another example with a generated inline response which shows the behavior - I'll attach it to the issue I need to open. |
6 tasks
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Replacing it with
camelizeand will completely remove it in 4.x releasecc @OpenAPITools/generator-core-team