Skip to content

[Spring] Add apiFirst option #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 6 commits into from
Jun 7, 2018
Merged

[Spring] Add apiFirst option #184

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47f9683
[Spring] Add apiFirst option
cbornet May 30, 2018
6a5c7d8
Git diff to see what's wrong
cbornet May 31, 2018
1d804f4
Git diff to see what's wrong
cbornet May 31, 2018
2eed9e1
Merge remote-tracking branch 'origin/master' into pull_184
jmini Jun 6, 2018
7882c18
Update bin/ensure-up-to-date
jmini Jun 6, 2018
5041987
Run bin/ensure-up-to-date
jmini Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/ensure-up-to-date
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ sleep 5
./bin/openapi3/php-petstore.sh

# Check:
echo "Perform git diff"
Copy link
Member

@jmini jmini Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have let this 3 lines (echo, git diff and git status) inside the if... We do not need them in the OK case.

git --no-pager diff
git status
if [ -n "$(git status --porcelain)" ]; then
echo "UNCOMMITTED CHANGES ERROR"
echo "There are uncommitted changes in working tree after execution of 'bin/ensure-up-to-date'"
Expand Down