Skip to content

Python: Update api_doc_example for multiple auth #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wing328 merged 1 commit into from
Jan 11, 2019
Merged

Python: Update api_doc_example for multiple auth #1870

wing328 merged 1 commit into from
Jan 11, 2019

Conversation

@cognifloyd
Copy link
Contributor

@cognifloyd cognifloyd commented Jan 10, 2019

PR checklist

  • Read the contribution guidelines.
  • [-] Ran the shell script under ./bin/ to update Petstore sample ... only a doc change
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Python technical committee: @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10)

Description of the PR

APIs may have more than one auth method (for example both an app key and basic auth).
This changes the example to only initialize the config option once instead of once per auth method.

@cognifloyd
Python: Update api_doc_example for multiple auth
32eafec 
APIs may more than one auth method (for example both an app key and basic auth).
This changes the example to only initialize the config option once instead of once per auth method.
wing328
wing328 approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 00a9cfd into OpenAPITools:master Jan 11, 2019
@wing328 wing328 added this to the 4.0.0 milestone Jan 11, 2019
jimschubert added a commit that referenced this pull request Jan 12, 2019
@jimschubert
Merge branch 'master' into fix-path-cleaning-on-write
50bfd06 
* master:
  Add links to Patreon account (#1887)
  Python AIOHTTP server generator (#1470)
  Fix a problem that points to a folder that doesn't exist (#1863)
  Python: Update api_doc_example for multiple auth (#1870)
  [gradle] Add 4 boolean properties supported by codegenConfigurator (#1881)
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@cognifloyd @wing328
Python: Update api_doc_example for multiple auth (OpenAPITools#1870)
7f337f6 
APIs may more than one auth method (for example both an app key and basic auth).
This changes the example to only initialize the config option once instead of once per auth method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328 wing328 wing328 approved these changes

Assignees

No one assigned

Labels

Client: Python Enhancement: Feature Feature: Documentation

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@cognifloyd @wing328