-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Fix: Remove spec 3 references keys in imports for TypeScript #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
macjohnny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Override names - requires: #2046 |
|
@wing328 don't think we are going to be able to create a sensible import { FirstRuleDefinition | SecondRuleDefinition } from './firstRuleDefinitionSecondRuleDefinition';
export interface CustomRule {
ruleId?: string | null;
definition?: FirstRuleDefinition | SecondRuleDefinition | null;
}I think we need to approach this in a new manner. import { FirstRuleDefinition} from './firstRuleDefinition';
import { SecondRuleDefinition } from './secondRuleDefinition';
export interface CustomRule {
ruleId?: string | null;
definition?: FirstRuleDefinition | SecondRuleDefinition | null;
} |
|
Let's have another chat in the coming week when you've time. |
|
@wing328 updated the solution. Works for TS |
|
@smasala could you please fix the merge conflicts? |
This reverts commit 7e58719.
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java
import missing package, merge error.
|
@smasala the CI is failing, can you have a look at it? |
…rator into name-ref-fix # Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/typescript/typescriptnode/TypeScriptNodeClientCodegenTest.java
macjohnny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hello, is there any chance you could release this to the NPM package? as a minor release? Thanks! @wing328 @macjohnny |
|
this will be released in 4.1.0, probably this week |
PR checklist
masterDescription of the PR
Sanitizes model names by removing
anyOfandoneOfspec reference keys in model imports.Fixes: #1913
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)