Skip to content

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jan 22, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add migration note about the change in basePath from https://localhost to http://locallhost (http without s)

cc @tomplus

@wing328 wing328 added this to the 4.0.0 milestone Jan 22, 2019
@wing328 wing328 merged commit 47e262f into master Jan 22, 2019
@wing328 wing328 deleted the wing328-patch-basepath branch January 22, 2019 08:56
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Add migration note about change in basePath

* update body parameter note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants