[Ruby] Fix enum expansion in Ruby client #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autopp
force-pushed
the
fix-enum-expansion-in-ruby-client
branch
from
99f63b1 to
641cf0b
Compare
autopp
changed the title
autopp
force-pushed
the
fix-enum-expansion-in-ruby-client
branch
from
641cf0b to
342da99
Compare
wing328
approved these changes
Feb 11, 2019
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
Thanks for the fix, which looks good to me 👍
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…Tools#2104) * use double-quote string for enum value (OpenAPITools#2081) * use enumVars in templates for Ruby client (OpenAPITools#2081) * delete unnecessary line in enum model of Ruby client (OpenAPITools#2081) * update samples of Ruby client (OpenAPITools#2081)
wing328
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Fix #2081.
toEnumValuenow returns double-quote string.{{#values}}in{{#allowableValues}}changed to{{#enumVars}}.