Skip to content

[PHP-Symfony] Validate input objects #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ackintosh merged 1 commit into from
Feb 14, 2019
Merged

[PHP-Symfony] Validate input objects #2144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion modules/openapi-generator/src/main/resources/php-symfony/api_input_validation.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
{{#isContainer}}
{{#items}}
$asserts[] = new Assert\All([
new Assert\Type("{{dataType}}")
new Assert\Type("{{dataType}}"),
{{^isPrimitiveType}}
new Assert\Valid(),
{{/isPrimitiveType}}
]);
{{/items}}
{{/isContainer}}
Expand All @@ -36,6 +39,9 @@
{{/isFile}}
{{^isFile}}
$asserts[] = new Assert\Type("{{dataType}}");
{{^isPrimitiveType}}
$asserts[] = new Assert\Valid();
{{/isPrimitiveType}}
{{/isFile}}
{{/isDateTime}}
{{/isDate}}
Expand Down
6 changes: 4 additions & 2 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/PetController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public function addPetAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\Pet");
$asserts[] = new Assert\Valid();
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -274,7 +275,7 @@ public function findPetsByStatusAction(Request $request)
new Assert\Choice([ "available", "pending", "sold" ])
]);
$asserts[] = new Assert\All([
new Assert\Type("string")
new Assert\Type("string"),
]);
$response = $this->validate($status, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -362,7 +363,7 @@ public function findPetsByTagsAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\All([
new Assert\Type("string")
new Assert\Type("string"),
]);
$response = $this->validate($tags, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -546,6 +547,7 @@ public function updatePetAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\Pet");
$asserts[] = new Assert\Valid();
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down
1 change: 1 addition & 0 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/StoreController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,7 @@ public function placeOrderAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\Order");
$asserts[] = new Assert\Valid();
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down
8 changes: 6 additions & 2 deletions samples/server/petstore/php-symfony/SymfonyBundle-php/Controller/UserController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public function createUserAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\User");
$asserts[] = new Assert\Valid();
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down Expand Up @@ -180,7 +181,8 @@ public function createUsersWithArrayInputAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\All([
new Assert\Type("OpenAPI\Server\Model\User")
new Assert\Type("OpenAPI\Server\Model\User"),
new Assert\Valid(),
]);
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -268,7 +270,8 @@ public function createUsersWithListInputAction(Request $request)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\All([
new Assert\Type("OpenAPI\Server\Model\User")
new Assert\Type("OpenAPI\Server\Model\User"),
new Assert\Valid(),
]);
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
Expand Down Expand Up @@ -680,6 +683,7 @@ public function updateUserAction(Request $request, $username)
$asserts = [];
$asserts[] = new Assert\NotNull();
$asserts[] = new Assert\Type("OpenAPI\Server\Model\User");
$asserts[] = new Assert\Valid();
$response = $this->validate($body, $asserts);
if ($response instanceof Response) {
return $response;
Expand Down