Skip to content

Conversation

@karismann
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.

Description of the PR

fix issue #2131 :
add missing General Configuration parameters in Maven Plugin README
fix word typo in generate description option

@auto-labeler
Copy link

auto-labeler bot commented Feb 14, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@karismann
Copy link
Contributor Author

cc @jimschubert

@jimschubert
Copy link
Member

That's a lot more missing properties than I thought there'd be!
I'm in mobile currently, but I'll look at the Shippable failure as soon as I can.

@jimschubert jimschubert merged commit 027e6c4 into OpenAPITools:master Feb 17, 2019
@karismann karismann deleted the issue2131-plugin-maven-README-missing-parameters branch February 18, 2019 09:52
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328 wing328 added this to the 4.0.0 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants