Skip to content

Conversation

@dalewking
Copy link
Contributor

Description of the PR

See #2396

The only authentication scheme that was actually usable on dart was oauth. These changes to allow using ApiKeyAuth and basic authentication. It also takes the step that when the access information is set it isn't in public properties so cannot be simply read.

@ircecho @swipesight @jaumard

@auto-labeler
Copy link

auto-labeler bot commented Mar 15, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@dalewking
Copy link
Contributor Author

Closing and re-opening to kick Travis to build again

@dalewking dalewking closed this Mar 16, 2019
@dalewking dalewking reopened this Mar 16, 2019
@wing328
Copy link
Member

wing328 commented Mar 17, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 4.0.0 milestone Mar 17, 2019
@cedricziel
Copy link
Contributor

Added a small PR to your branch (dalewking#1). This incorporates your changes into the top-level README and expands the basic auth so it's easier to use.

@dalewking
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account

Amended the commits and fixed. Was using my work email address

@wing328
Copy link
Member

wing328 commented Mar 18, 2019

The new commits are correctly linked to your account You can also add your work email address as the secondary email address in the Github account so that the first 2 commits are correctly linked to your account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants