[cli][gradle] Adds package name as a global option #2557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI supports other package-related options (--api-package, --model-package, --invoker-package). This aligns those options with --package-name to avoid confusion about how to configure these options where those are supported. This intentionally does not apply a packageName getter/setter to DefaultCodegen to reduce the footprint of this change.
This makes packageName available as a global option, beside apiPackage, modelPackage, and invokerPackage to reduce potential confusion about how to configure the four of these options by generators which support them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Extending on #2429, this adds package name globally in the CLI and Gradle Plugins. We have options for api package, model package, and invoker package globally. Configuring the three of these plus
packageNamein different locations can be confusing for the generators which support all four options.There may be concern that
packageNameis made a "global" option and isn't supported by all generators, but there are quite a few options that aren't supported by many generators (e.g. allpackagerelated options, file post processing, etc). This favors usability in these cases.I've opened #2556 for discussions about options which may or may not belong globally.