Skip to content

typescript-fetch: Fix type errors in generated code #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macjohnny merged 1 commit into from
Aug 10, 2019
Merged

typescript-fetch: Fix type errors in generated code #3605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix #3604 by adding undefined as return type to headers and credentia… 
…ls methods in runtime.ts
  • Loading branch information
Gustaf Barkeling committed Aug 9, 2019
commit 009dfaf46456910aadbd52025a9714918ab7bba3
4 changes: 2 additions & 2 deletions modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,11 @@ export class Configuration {
return undefined;
}

get headers(): HTTPHeaders {
get headers(): HTTPHeaders | undefined {
return this.configuration.headers;
}

get credentials(): RequestCredentials {
get credentials(): RequestCredentials | undefined {
return this.configuration.credentials;
}
}
Expand Down
4 changes: 2 additions & 2 deletions samples/client/petstore/typescript-fetch/builds/default/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ export class Configuration {
return undefined;
}

get headers(): HTTPHeaders {
get headers(): HTTPHeaders | undefined {
return this.configuration.headers;
}

get credentials(): RequestCredentials {
get credentials(): RequestCredentials | undefined {
return this.configuration.credentials;
}
}
Expand Down
4 changes: 2 additions & 2 deletions samples/client/petstore/typescript-fetch/builds/es6-target/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ export class Configuration {
return undefined;
}

get headers(): HTTPHeaders {
get headers(): HTTPHeaders | undefined {
return this.configuration.headers;
}

get credentials(): RequestCredentials {
get credentials(): RequestCredentials | undefined {
return this.configuration.credentials;
}
}
Expand Down
4 changes: 2 additions & 2 deletions samples/client/petstore/typescript-fetch/builds/multiple-parameters/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ export class Configuration {
return undefined;
}

get headers(): HTTPHeaders {
get headers(): HTTPHeaders | undefined {
return this.configuration.headers;
}

get credentials(): RequestCredentials {
get credentials(): RequestCredentials | undefined {
return this.configuration.credentials;
}
}
Expand Down
4 changes: 2 additions & 2 deletions samples/client/petstore/typescript-fetch/builds/with-interfaces/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ export class Configuration {
return undefined;
}

get headers(): HTTPHeaders {
get headers(): HTTPHeaders | undefined {
return this.configuration.headers;
}

get credentials(): RequestCredentials {
get credentials(): RequestCredentials | undefined {
return this.configuration.credentials;
}
}
Expand Down
4 changes: 2 additions & 2 deletions samples/client/petstore/typescript-fetch/builds/with-npm-version/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@ export class Configuration {
return undefined;
}

get headers(): HTTPHeaders {
get headers(): HTTPHeaders | undefined {
return this.configuration.headers;
}

get credentials(): RequestCredentials {
get credentials(): RequestCredentials | undefined {
return this.configuration.credentials;
}
}
Expand Down